Merged
Conversation
…nning the application under Electron: When user starts dragging an item, as soon finger leaves the element, _mouseLeave is run, called from @dd-touch.js simulating mouse event. But on next move, _mouseEnter is run even though pointer has not reentered the element. _mouseEnter is not called by @dd-touch.js as part of simulating mouse, but is called as a real mouse event by browser. Strange part is that event.screenX from the _mouseEvent argument, gives a coordinate that matches where finger started dragging, not the coordinate of where the finger left the element.
Member
|
thanks for the fix! |
Author
|
Thanks for merging. Do you have an idea of when it will be available on NPM? |
adumesny
added a commit
to adumesny/gridstack.js
that referenced
this pull request
Dec 21, 2025
* fix gridstack#3214 and better fix gridstack#3191 * linux fix should have used existing `DDTouch.touchHandled` which is set to true while handling touch events since a computer can have both touch and real mouse event * added safetyc heck to make sure flag is reset if we're missing 'touchend' event.
Member
|
@jemunk please verify the correct fix (only tested in simulation) which will go out in 12.4.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed this touch issue happening on Linux device with touch screen running the application under Electron (Chromium):
When user starts dragging an item, as soon finger leaves the element, _mouseLeave is run, called from @dd-touch.js simulating mouse event. But on next move, _mouseEnter is run even though pointer has not reentered the element. _mouseEnter is not called by @dd-touch.js as part of simulating mouse, but is called as a real mouse event by browser. Strange part is that event.screenX from the _mouseEvent argument, gives a coordinate that matches where finger started dragging, not the coordinate of where the finger left the element.
Checklist
yarn test)